suddjian commented on a change in pull request #9210: Add maximize and minimize
feature to charts
URL:
https://github.com/apache/incubator-superset/pull/9210#discussion_r386650316
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -109,12 +115,14 @@ class SliceHeaderControls extends React.PureComponent {
updatedDttm,
componentId,
addDangerToast,
+ isFullSize,
} = this.props;
const cachedWhen = moment.utc(cachedDttm).fromNow();
const updatedWhen = updatedDttm ? moment.utc(updatedDttm).fromNow() : '';
const refreshTooltip = isCached
? t('Cached %s', cachedWhen)
: (updatedWhen && t('Fetched %s', updatedWhen)) || '';
+ const resizeLabel = isFullSize ? 'Minimize' : 'Maximize';
Review comment:
Should use translations
```suggestion
const resizeLabel = isFullSize ? t('Minimize') : t('Maximize');
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
