oashton commented on issue #9210: Add maximize and minimize feature to charts URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593990492 > Can you explain what `resizeEvent` does that cannot be done with `isFullSize` alone? The `Chart.jsx shouldComponentUpdate` method has some logic to determine if the chart should update. From what I understood, I needed to add a new conditional to force the update, that condition is the resize event, the `isFullSize` only represent the state not if new event (resize) was triggered. 
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
