[GitHub] [incubator-superset] etr2460 opened a new pull request #9249: Replace No data error with help message

[GitBox]

etr2460 opened a new pull request #9249: Replace No data error with help message
URL: https://github.com/apache/incubator-superset/pull/9249
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   This PR updates the behavior of viz.py to not return an error when the 
results of a viz query returns 0 rows. It makes use of the update to SuperChart 
for handling this on the client side.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   <img width="1063" alt="Screen Shot 2020-03-05 at 2 26 11 PM" 
src="https://user-images.githubusercontent.com/7409244/76031804-4bc9d500-5eed-11ea-9739-124a7f9d8e5a.png";>
   
   After:
   <img width="1263" alt="Screen Shot 2020-03-04 at 12 48 56 PM" 
src="https://user-images.githubusercontent.com/7409244/76031817-52f0e300-5eed-11ea-8999-50b62cc48e40.png";>
   
   
   ### TEST PLAN
   test all viz types with a query that returns 0 rows, ensure the error 
message is shown and there aren't any js errors.
   
   test all viz types with a query that returns some number of rows, and ensure 
the error message isn't shown
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   to: @john-bodley @kristw @mistercrunch @villebro 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org