john-bodley commented on a change in pull request #9249: Replace No data error
with help message
URL:
https://github.com/apache/incubator-superset/pull/9249#discussion_r388635110
##########
File path: superset/viz.py
##########
@@ -1178,7 +1190,7 @@ def to_series(self, df, classed="", title_suffix=""):
chart_data.append(d)
return chart_data
- def process_data(self, df, aggregate=False):
+ def process_data(self, df: pd.DataFrame, aggregate=False):
Review comment:
Nit. Whilst you here could you type the `aggregate` argument and return type?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
