etr2460 commented on a change in pull request #9249: Replace No data error with
help message
URL:
https://github.com/apache/incubator-superset/pull/9249#discussion_r389148850
##########
File path: superset/viz.py
##########
@@ -1907,7 +1936,7 @@ def get_df(self, query_obj: Optional[Dict[str, Any]] =
None) -> pd.DataFrame:
return pd.DataFrame()
def get_data(self, df: pd.DataFrame) -> VizData:
- return {}
Review comment:
Context was discussed in the meetup; adding here...
If data is null or empty on the client side we render the `no results`
message. iframes should never have data, but should still render the base
chart, so i'm adding some dummy data here to ensure iframe charts render
properly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
