[GitHub] [incubator-superset] john-bodley opened a new pull request #9572: [fix] Adding URL params to cache key if present

Fri, 17 Apr 2020 11:54:14 -0700 

john-bodley opened a new pull request #9572: [fix] Adding URL params to cache 
key if present
URL: https://github.com/apache/incubator-superset/pull/9572
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   The URL parameters were not being used in the cache key resulting in issues 
per the attached screenshot. This PR adds the URL params to the cache key (only 
if present to prevent invalidating existing cache keys). Note that the presence 
of the URL params does not imply that the resulting payload will be different 
(it's up to the datasource to leverage the params), however inspecting the 
datasource seems like overkill.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   <img width="1166" alt="Screen Shot 2020-04-17 at 11 52 20 AM" 
src="https://user-images.githubusercontent.com/4567245/79603872-f5ca7e80-80a1-11ea-925e-078c8d8a0a84.png";>
   
   #### After 
   
   <img width="1168" alt="Screen Shot 2020-04-17 at 11 51 25 AM" 
src="https://user-images.githubusercontent.com/4567245/79603867-f3682480-80a1-11ea-8a02-e09912d734d2.png";>
   
   ### TEST PLAN
   
   Added unit test.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   to: @villebro 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to