john-bodley commented on a change in pull request #9572: [fix] Adding URL
params to cache key if present
URL:
https://github.com/apache/incubator-superset/pull/9572#discussion_r410413921
##########
File path: tests/core_tests.py
##########
@@ -173,7 +173,6 @@ def test_viz_cache_key(self):
viz = slc.viz
qobj = viz.query_obj()
cache_key = viz.cache_key(qobj)
- self.assertEqual(cache_key, viz.cache_key(qobj))
Review comment:
This seems unnecessary, i.e., it's equivalent to,
```python
self.assertEqual(viz.cache_key(qobj), viz.cache_key(qobj))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
