villebro commented on issue #9572: [fix] Adding URL params to cache key if present URL: https://github.com/apache/incubator-superset/pull/9572#issuecomment-616206574 @john-bodley the way I see it, `url_params` is a slightly special property in chart metadata, and should only be regarded as default values that are overridden if the parameter is present in the URL. It's worth keeping in mind that adding `url_params` to the cache key will invalidate the cache key for every query/chart in a dashboard if a query parameter is added to the URL, even if it is not used by the query. It is for this purpose that `cache_key_wrapper` was added, ie. making sure that any additional variable that needs to be considered in the query is considered in the cache key. Given the fact that using `cache_key_wrapper` can solve this problem without impacting other charts/queries, I would propose using that for now.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
