graceguo-supercat opened a new pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Currently in explore view, inline override chart title without confirmation behavior is very confusing: 1. user open a chart 2. as long as he/she is the chart owner, he/she can click the chart title, and inline edit chart title. Superset will automatically overwrite new chart title in the database, without user clicking a confirm button. User may not realize the original chart title is overwritten. 3. if user wants to make a copy of the original chart, they may edit title first then click Save button and choose "Save as". But at this moment the original title is already changed. Proposed solution: 1. user can still inline edit chart title, but Superset won't overwrite chart title right away. The changes is only in front-end, not change backend slice data. 2. Only when user click explore view's Save button, and choose save as or overwrite, the new title will be saved with other changes. If user choose save as, original chart title won't be updated. ### TEST PLAN CI and manual test ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
