etr2460 commented on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630386661
to answer your questions: 1. When you first name a chart, we save the current state of everything to a new chart with that name. This is a pretty standard use case, e.g. I set up a chart to how i like it, name it, then send it to someone/add it to a dashboard. 2. I think because we have the `altered` label, it should be clear enough to the user when they've made some changes that aren't saved I think we should be careful about breaking the happy path here and only address the problem cases. The problem here is that changing a chart title instantly saves and overwrites the chart. If the chart was never saved before, then there's nothing to overwrite, so autosaving on the first title change doesn't seem too inconsistent/messy to me ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
