etr2460 commented on pull request #9817:
URL: 
https://github.com/apache/incubator-superset/pull/9817#issuecomment-629688078


   omg, thank you so much for fixing this. i've made this mistake sooo many 
times.
   
   one consideration, do you think the behavior should be different on the 
initial naming of the chart? So if the user changes the name from `- untitled` 
to something, then we treat that as the first time saving the chart and write 
to the backend, but any other time we don't overwrite the name until the user 
explicitly clicks the save button.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to