villebro commented on a change in pull request #9854:
URL:
https://github.com/apache/incubator-superset/pull/9854#discussion_r427787145
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1068,7 +1080,7 @@ def mutator(df: pd.DataFrame) -> None:
"""
labels_expected = query_str_ext.labels_expected
- if df is not None and not df.empty:
+ if df is not None:
Review comment:
During testing I noticed that column names were not being renamed back
to their original format if the dataframe was empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
