john-bodley commented on a change in pull request #9854:
URL:
https://github.com/apache/incubator-superset/pull/9854#discussion_r428033535
##########
File path: superset/connectors/sqla/models.py
##########
@@ -167,15 +167,26 @@ def is_temporal(self) -> bool:
self.type, utils.DbColumnType.TEMPORAL
)
- def get_sqla_col(self, label: Optional[str] = None) -> Column:
- label = label or self.column_name
+ def get_sqla_col(
Review comment:
I’m kind of surprised that SQLAlchemy isn’t dealing with the labels
correctly. Are we not constructing the SQL query in the appropriate manner?
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1068,7 +1080,7 @@ def mutator(df: pd.DataFrame) -> None:
"""
labels_expected = query_str_ext.labels_expected
- if df is not None and not df.empty:
+ if df is not None:
Review comment:
Somewhat unrelated but I thought we banished `df` being `None`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
