john-bodley commented on a change in pull request #9854:
URL:
https://github.com/apache/incubator-superset/pull/9854#discussion_r428219361
##########
File path: superset/connectors/sqla/models.py
##########
@@ -167,15 +167,26 @@ def is_temporal(self) -> bool:
self.type, utils.DbColumnType.TEMPORAL
)
- def get_sqla_col(self, label: Optional[str] = None) -> Column:
- label = label or self.column_name
+ def get_sqla_col(
Review comment:
@villebro do you think there is merit in trying to fix the BigQuery
DB-API instead, i.e., overriding the
[`visit_label`](https://github.com/obeattie/sqlalchemy/blob/376007fed7746d494dcb0166b22e512bfece02cd/lib/sqlalchemy/sql/compiler.py#L285)
method? Note I've had to do this for a custom dialect.
This would ensure that i) this would be fixed for all BigQuery use cases
(and not just those emanating from Superset), and ii) reduce the need for
custom Superset overrides.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
