nytai commented on a change in pull request #10094:
URL:
https://github.com/apache/incubator-superset/pull/10094#discussion_r443911365
##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -63,11 +63,10 @@ const StyledHeader = styled.header`
`;
interface Props {
- createButton: { name: string; url: string | null };
- canCreate: boolean;
- label: string;
+ createButton?: { name: string; url: string | null };
+ canCreate?: boolean;
name: string;
- childs: Array<{ label: string; name: string; url: string }>;
+ childs?: Array<{ label: string; name: string; url: string }>;
Review comment:
This is legacy terminology from FAB's menu structure and it's the same
in the react menu component,
https://github.com/preset-io/incubator-superset/blob/master/superset-frontend/src/components/Menu/MenuObject.jsx#L28
Also I think children will conflict with react's built in props
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
