nytai commented on a change in pull request #10094:
URL:
https://github.com/apache/incubator-superset/pull/10094#discussion_r444383675
##########
File path: superset-frontend/src/components/AvatarIcon.tsx
##########
@@ -42,18 +43,26 @@ export default function AvatarIcon({
lastName,
userName,
iconSize,
+ textSize,
}: Props) {
const uniqueKey = `${tableName}-${userName}`;
const fullName = `${firstName} ${lastName}`;
return (
- <ConfigProvider colors={colorList && colorList.colors}>
- <OverlayTrigger
- placement="right"
- overlay={<Tooltip id={`${uniqueKey}-tooltip`}>{fullName}</Tooltip>}
- >
- <StyledAvatar key={uniqueKey} name={fullName} size={iconSize} round />
- </OverlayTrigger>
- </ConfigProvider>
+ <TooltipWrapper
+ placement="bottom"
+ label={`${uniqueKey}-tooltip`}
+ tooltip={fullName}
+ >
+ <ConfigProvider colors={colorList && colorList.colors}>
+ <StyledAvatar
+ key={uniqueKey}
+ name={fullName}
+ size={String(iconSize)}
+ textSizeRatio={Number(iconSize) / textSize}
Review comment:
Ah yes, looks like I had two competing approaches here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
