rusackas commented on a change in pull request #10094:
URL:
https://github.com/apache/incubator-superset/pull/10094#discussion_r444471452
##########
File path: superset-frontend/src/components/AvatarIcon.tsx
##########
@@ -19,15 +19,16 @@
import React from 'react';
import styled from '@superset-ui/style';
import { getCategoricalSchemeRegistry } from '@superset-ui/color';
-import { Tooltip, OverlayTrigger } from 'react-bootstrap';
import Avatar, { ConfigProvider } from 'react-avatar';
+import TooltipWrapper from 'src/components/TooltipWrapper';
Review comment:
Just a comment that's out of scope for this PR, and a bit pedantic, but
it might be nice to just call this component `Tooltip` since I suspect _most_
of our Superset components going forward will be wrappers for some
react-bootstrap/antd/whateverLibrary component. I would just name the tool
semantically, lest we start calling everything a Wrapper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
