rusackas commented on a change in pull request #10298:
URL:
https://github.com/apache/incubator-superset/pull/10298#discussion_r454519472
##########
File path:
superset-frontend/spec/javascripts/components/ListView/ListView_spec.jsx
##########
@@ -72,8 +73,15 @@ const mockedProps = {
pageSize: 1,
fetchData: jest.fn(() => []),
loading: false,
+ bulkSelectEnabled: true,
Review comment:
Maybe worth adding a sanity check test where `bulkSelectEnabled: false`
to make sure it loads correctly and the buttons _aren't_ in the DOM? ¯\_(ツ)_/¯
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
