rusackas commented on a change in pull request #10298:
URL:
https://github.com/apache/incubator-superset/pull/10298#discussion_r454540720
##########
File path: superset-frontend/src/views/dashboardList/DashboardList.tsx
##########
@@ -45,23 +45,24 @@ interface Props {
}
interface State {
- dashboards: any[];
+ bulkSelectEnabled: boolean;
dashboardCount: number;
- loading: boolean;
+ dashboards: any[];
Review comment:
Not sure if it's worth the effort, but if instead of `dashboard____ `
keys, these could be made more generic, e.g. `itemCount`, and then `ListView`
could export a shared/reusable interface?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
