rusackas commented on a change in pull request #10298:
URL:
https://github.com/apache/incubator-superset/pull/10298#discussion_r454527282
##########
File path: superset-frontend/src/components/ListView/ListView.tsx
##########
@@ -155,6 +205,37 @@ const ListView: FunctionComponent<Props> = ({
)}
</div>
<div className="body">
+ {bulkSelectEnabled && (
+ <BulkSelectWrapper bsStyle="info" onDismiss={disableBulkSelect}>
+ <div className="selectedCopy">
+ {renderBulkSelectCopy(selectedFlatRows)}
+ </div>
+ {Boolean(selectedFlatRows.length) && (
+ <>
+ <span
+ role="button"
+ tabIndex={0}
+ className="deselect-all"
+ onClick={() => toggleAllRowsSelected(false)}
+ >
+ {t('Deselect All')}
+ </span>
+ <div className="divider" />
+ {bulkActions.map(action => (
+ <Button
Review comment:
Should this be an instance of SupersetButton?
Also, I'm assuming the margin-left style applied is to add a gap between
buttons. If so, maybe we can kill off the margin-left style in this CSS, and
add it to the SupersetButton component, e.g.:
```
margin-left: ${({ theme }) => theme.gridUnit * 4}px;
&:first-of-type {
margin-left: 0;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
