ktmud commented on a change in pull request #10275:
URL:
https://github.com/apache/incubator-superset/pull/10275#discussion_r455280523
##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -259,6 +257,14 @@ div.Workspace {
&:active {
background: none;
}
+
+ svg {
+ vertical-align: middle;
+
+ &:hover {
+ cursor: pointer;
+ }
+ }
Review comment:
Actually, you don't have to do anything. Just apply `cursor` directly to
`CloseIcon` since it's a valid attribute for SVG elements. `<CloseIcon
role="button" cursor="pointer">`.
You also don't have to `&:hover` for cursor attributes, since it already
only applies when an element is hovered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
