etr2460 commented on a change in pull request #10275:
URL:
https://github.com/apache/incubator-superset/pull/10275#discussion_r455262965
##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -259,6 +257,14 @@ div.Workspace {
&:active {
background: none;
}
+
+ svg {
+ vertical-align: middle;
+
+ &:hover {
+ cursor: pointer;
+ }
+ }
Review comment:
Instead of this, you can add the styles in JS as follows:
```tsx
const CloseIcon = styled(Icon)`
vertical-align: middle;
&:hover {
cursor: pointer;
}
`;
// then inside the render function do
<CloseIcon role="button" tabIndex={0} name="cancel-x" onClick={() =>
this.removeQueryEditor(qe)} />
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
