graceguo-supercat commented on a change in pull request #10275:
URL:
https://github.com/apache/incubator-superset/pull/10275#discussion_r455268601
##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -259,6 +257,14 @@ div.Workspace {
&:active {
background: none;
}
+
+ svg {
+ vertical-align: middle;
+
+ &:hover {
+ cursor: pointer;
+ }
+ }
Review comment:
If every time use our own svg need this much trouble, i would rather use
Font-Awesome, they took care of these troubles (like `role="button"
tabIndex={0}`) already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
