[GitHub] [incubator-superset] etr2460 opened a new pull request #10473: feat: refactor error components and add database issue code

[GitBox]

etr2460 opened a new pull request #10473:
URL: https://github.com/apache/incubator-superset/pull/10473


   ### SUMMARY
   - Refactors the `TimeoutErrorMessage` into a generic `ErrorAlert` component
   - Adds the `DatabaseErrorMessage` component for handling all generic 
database errors
   - Uses the `ErrorAlert` component to handle all other errors, removing the 
need for the Bootstrap Alert
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   New UI:
   <img width="497" alt="Screen Shot 2020-07-29 at 10 52 07 AM" 
src="https://user-images.githubusercontent.com/7409244/88836624-d4425e00-d18b-11ea-9765-dc361a545bff.png";>
   <img width="657" alt="Screen Shot 2020-07-29 at 10 52 14 AM" 
src="https://user-images.githubusercontent.com/7409244/88836625-d4425e00-d18b-11ea-8222-286b3843d806.png";>
   <img width="1273" alt="Screen Shot 2020-07-29 at 10 52 42 AM" 
src="https://user-images.githubusercontent.com/7409244/88836630-d5738b00-d18b-11ea-8ba7-26d319e2efe8.png";>
   <img width="1588" alt="Screen Shot 2020-07-29 at 11 07 55 AM" 
src="https://user-images.githubusercontent.com/7409244/88836632-d60c2180-d18b-11ea-9b40-22c1101fd4c3.png";>
   <img width="486" alt="Screen Shot 2020-07-29 at 10 51 38 AM" 
src="https://user-images.githubusercontent.com/7409244/88836620-d3113100-d18b-11ea-8bd6-b01a2d9d3e72.png";>
   
   ### TEST PLAN
   CI, force errors throughout dashboards, charts, and sql lab and see correct 
rendering, typecheck everything
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   to: @john-bodley @ktmud @nytai


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org