john-bodley commented on a change in pull request #10473:
URL:
https://github.com/apache/incubator-superset/pull/10473#discussion_r464633078
##########
File path: superset/db_engine_specs/athena.py
##########
@@ -23,6 +23,7 @@
class AthenaEngineSpec(BaseEngineSpec):
engine = "awsathena"
+ engine_name = "AWS Athena"
Review comment:
```suggestion
engine_name = "Amazon Athena"
```
##########
File path: superset/db_engine_specs/cockroachdb.py
##########
@@ -19,3 +19,4 @@
class CockroachDbEngineSpec(PostgresEngineSpec):
engine = "cockroachdb"
+ engine_name = "Cockroach DB"
Review comment:
```suggestion
engine_name = "CockroachDB"
```
##########
File path: superset/db_engine_specs/hana.py
##########
@@ -24,6 +24,7 @@
class HanaEngineSpec(PostgresBaseEngineSpec):
engine = "hana"
+ engine_name = "Hana"
Review comment:
```suggestion
engine_name = "SAP HANA"
```
##########
File path: superset/db_engine_specs/teradata.py
##########
@@ -21,6 +21,7 @@ class TeradataEngineSpec(BaseEngineSpec):
"""Dialect for Teradata DB."""
engine = "teradata"
+ engine_name = "Teradata DB"
Review comment:
```suggestion
engine_name = "Teradata"
```
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -38,6 +38,7 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
""" Abstract class for Postgres 'like' databases """
engine = ""
+ engine_name = "Postgres"
Review comment:
```suggestion
engine_name = "PostgreSQL"
```
##########
File path: superset/db_engine_specs/redshift.py
##########
@@ -19,6 +19,7 @@
class RedshiftEngineSpec(PostgresBaseEngineSpec):
engine = "redshift"
+ engine_name = "Redshift"
Review comment:
```suggestion
engine_name = "Amazon Redshift"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
