etr2460 commented on a change in pull request #10473:
URL:
https://github.com/apache/incubator-superset/pull/10473#discussion_r465450943
##########
File path: superset/db_engine_specs/base.py
##########
@@ -137,6 +137,7 @@ class BaseEngineSpec: # pylint:
disable=too-many-public-methods
"""Abstract class for database engine specific configurations"""
engine = "base" # str as defined in sqlalchemy.engine.engine
+ engine_name = "Base Database"
Review comment:
sgtm, simply removing this line should be fine then right?
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
