mistercrunch commented on pull request #10603: URL: https://github.com/apache/incubator-superset/pull/10603#issuecomment-674306281
I think that chart-level colors were a mistake and that we should revisit this. @nytai got tangled into this in the past and in some cases really makes the chart payload gigantic for no super good reason. I think Kim's intent originally was to preserve the dashboard-assigned colors when exploring the chart, but it really bloats the chart's properties. Plus it doesn't really play well with the many-to-many aspect of charts/dashboards, what if the chart is in two dashboards using different color schemes? Even if we wanted to preserve that context, we may want for the chart to only have a reference to the dashboard it's associated with (in that particular context), and use the metadata / color scheme from that dashboard. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
