graceguo-supercat edited a comment on pull request #10603: URL: https://github.com/apache/incubator-superset/pull/10603#issuecomment-675046048
I want to use this PR as a short term solution, to see how big impact those redundant label_colors in slices' form_data to dashboard performance (mostly for large dashboard used in airbnb). If the impact is big, we should do some refactoring for label_colors logic (long term solution): 1. instead of persist label_colors in form_data, we should pass the context to explore of which dashboard the user came from, and explore can retrieve whatever dashboard metadata (ie colors) that can affect the context of the chart itself. 2. do **not** save label_colors passed from dashboard when user save / copy slices (this is current behavior). 3. _db migration to remove label_colors from form_data_. -- not sure we should do this...what if user edit slice and want to set fixed color scheme for a slice? for both long term and short term solution, dashboard should not carry slice level color_labels. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
