etr2460 commented on pull request #10603: URL: https://github.com/apache/incubator-superset/pull/10603#issuecomment-675626359
Sorry, one clarification i'm not 100% sure of: Does this change affect the current user experience in any way? If a dashboard doesn't have colors defined, do we fall back to slice colors which will now be removed? I'd say, if this could change the user experience, then it might be safer to put this in a feature flag. If not, then i'm good to stamp this as an awesome optimization ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
