zuzana-vej opened a new issue #10655:
URL: https://github.com/apache/incubator-superset/issues/10655


   **Summary:**
   Saving metadata in Dashboard properties is broken. 
   
   **Steps to Reproduce:**
   1. Edit dashboard  --> Edit Dashboard Properties --> Advanced
   2. Change properties JSON, for example, totally remove default_filters or 
filter_scopes section
   3. Click Save button to close edit Modal
   4. Click Save button in dashboard header to finish edit mode
   
   **Investigation:**
   The root problem is, when you click the first save, new dashboard metadata 
send to backend, but after this save, this change is not updated in the 
dashboard redux store. So that when you click 2nd save, other old dashboard 
metadata sent to backend again, which overwrite the first request. The last 
change is overwritten.
   
   **Workaround:**
   There is a workaround that currently works (but it's not intuitive and 
likely we will have to explain it to all our users as they raise this issue): 
Click save only on modal, and not again on dashboard. Leave dashboard without 
saving the changes. The changes made on the Advanced Properties modal will 
actually get saved.
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version 
of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to