mistercrunch commented on issue #10655: URL: https://github.com/apache/incubator-superset/issues/10655#issuecomment-681406500
This seems related to the recent work that I did in this area. There's clearly components / modals that fetch and save straight to the endpoints without going through redux/actions here. This is convenient for the dashboard list view, but breaks down in the context where this is embedded in an app that does its own state management and triggers its own (delayed) save event. The deep fix involves things like: * merging all "properties" / modals into a single modal with all properties (CSS, properties, filter mapping, auto-refresh) * "Ok" on that screen should just merge into the redux store, and not commit to database until user hits save * look into the implications that this has on the list view's "edit action" modal. My vote there would be to NOT allow the modal there and force the user to open the dash, get in edit mode and do the changes there. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
