nytai commented on issue #10655: URL: https://github.com/apache/incubator-superset/issues/10655#issuecomment-683187050
I think ideally these modals should be more "dumb" to maximize reuse. OnSave should just delegate to a callback. This callback can be a redux action that just pushes the changes to state or a handler that fires a patch request... or both. I'd be more in favor of only allowing dashboard edits on the dashboard page if it loaded faster and we could jump straight into edit mode. Having to click through, wait for the dashboard to load, toggle edit mode, then click into the properties modal is quite a journey for a quick edit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
