dpgaspar commented on a change in pull request #10909:
URL:
https://github.com/apache/incubator-superset/pull/10909#discussion_r490938164
##########
File path: superset/models/helpers.py
##########
@@ -321,11 +322,11 @@ def template_params_dict(self) -> Dict[Any, Any]:
return json_to_dict(self.template_params) # type: ignore
-def _user_link(user: User) -> Union[Markup, str]: # pylint:
disable=no-self-use
- if not user:
+def _user_link(_user: User) -> Union[Markup, str]:
Review comment:
Can't we just remove the `# pylint: disable=no-self-use` on this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
