kkucharc commented on a change in pull request #10909:
URL:
https://github.com/apache/incubator-superset/pull/10909#discussion_r490983093
##########
File path: superset/models/helpers.py
##########
@@ -424,7 +425,10 @@ class ExtraJSONMixin:
def extra(self) -> Dict[str, Any]:
try:
return json.loads(self.extra_json)
- except Exception: # pylint: disable=broad-except
+ except (TypeError, JSONDecodeError) as exc:
+ logger.error(
+ "Unable to load an extra json: %r. Leaving empty.", exc,
exc_info=True
Review comment:
@dpgaspar do you mind to take a look again? I have one doubt: do you
think is it possible there could be raised exception while accessing
`self.extra_json` for logger?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
