kkucharc commented on a change in pull request #10909:
URL:
https://github.com/apache/incubator-superset/pull/10909#discussion_r490990123
##########
File path: superset/models/helpers.py
##########
@@ -424,7 +425,10 @@ class ExtraJSONMixin:
def extra(self) -> Dict[str, Any]:
try:
return json.loads(self.extra_json)
- except Exception: # pylint: disable=broad-except
+ except (TypeError, JSONDecodeError) as exc:
+ logger.error(
+ "Unable to load an extra json: %r. Leaving empty.", exc,
exc_info=True
Review comment:
Och, I see, then I just did the opposite thing! :) Reverting this change.
To be honest I think `JSONDecodeError` will show error message `%s: line %d
column %d (char %d)`. So it may contain partly some fragile data. Maybe it will
be better to log just the names of exceptions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
