rusackas commented on a change in pull request #10973:
URL:
https://github.com/apache/incubator-superset/pull/10973#discussion_r497997177
##########
File path:
superset-frontend/cypress-base/cypress/integration/explore/AdhocFilters.test.ts
##########
@@ -77,12 +77,17 @@ describe('AdhocFilters', () => {
cy.wait('@filterValues');
- cy.get('#filter-edit-popover #adhoc-filter-edit-tabs-tab-SQL').click();
- cy.get('#filter-edit-popover .ace_content').click();
- cy.get('#filter-edit-popover .ace_text-input').type(
- "'Amy' OR name = 'Bob'",
- );
- cy.get('#filter-edit-popover button').contains('Save').click();
+ cy.get('[data-test="filter-edit-popover"]')
+ .find('[data-test="adhoc-filter-edit-tabs"]')
+ .contains('Custom SQL')
Review comment:
Curious if you think we need to do the get->find->contains->click work
here, or if we should just make an explicit/specific attribute here and use it
directly, e.g. `cy.get('[data-test="adhoc-filter-edit-tab-custom-sql"]').click()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
