rusackas commented on a change in pull request #10973:
URL:
https://github.com/apache/incubator-superset/pull/10973#discussion_r498002989
##########
File path: superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
##########
@@ -115,6 +115,7 @@ export default function QueryAndSaveBtns({
data-toggle="modal"
disabled={saveButtonDisabled}
onClick={onSave}
+ data-test="save-button"
Review comment:
Wondering if something more-explicit, e.g. `explore-save-button` might
prevent a future issue where we have two `save-button` elements, like this one
and some other Save button in a Popover or Modal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
