rusackas commented on a change in pull request #10973:
URL:
https://github.com/apache/incubator-superset/pull/10973#discussion_r498003732
##########
File path: superset-frontend/src/explore/components/AdhocFilterEditPopover.jsx
##########
@@ -176,6 +181,7 @@ export default class AdhocFilterEditPopover extends
React.Component {
</Tabs>
<div>
<Button
+ data-test="modal-save-button"
Review comment:
this isn't a modal, but rather a popover. That said, I think again that
it might be wise to be specific, e.g. `save-adhoc-filter-button`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
