zuzana-vej opened a new issue #11190:
URL: https://github.com/apache/incubator-superset/issues/11190


   ~1week ago a change was merged redesigning the modal "Edit Datasource" on 
Chart Explore. It is not clear what should be the behavior of the section 
_Source_ on _Edit Dataset_:
   
   ![Screen Shot 2020-10-07 at 10 18 07 
AM](https://user-images.githubusercontent.com/61221714/95365033-6cdd1480-0886-11eb-8cad-04d34e931aab.png)
   
   
   ### Context
   
   **Use case 1: Changing datasource using Change Datasource**
   This change is local - only for the chart user has open. This works as 
expected.
   ![Screen Shot 2020-10-07 at 10 18 58 
AM](https://user-images.githubusercontent.com/61221714/95365152-9ac25900-0886-11eb-9d5c-44b468cc2c34.png)
   
   **Use case 2: Changing datasource using Edit Datasource --> Source** 
   Previously the Source tab was last on the right side, merged with settings. 
   It's unclear what is changing the source on this modal supposed to do. 
   Typically, any changes to "Edit Datasource" are applied globally to ALL 
CHARTS using the datasource. User is warned about this. 
   What is changing the source on the 1st tab actually supposed to do?
   ![Screen Shot 2020-10-07 at 10 21 37 
AM](https://user-images.githubusercontent.com/61221714/95366011-b5490200-0887-11eb-9aaa-61884a4468fc.png)
   
   
   ### Current behavior:
   Currently, if you change the name of table (Datasource) nothing happens.
   
   ![Screen Shot 2020-10-07 at 10 12 43 
AM](https://user-images.githubusercontent.com/61221714/95365956-a1050500-0887-11eb-8b6d-277b8446865b.png)
   
   After saving the change nothing happens to the chart, and the changes are 
not saved when opening the modal again.
   
   ### Expected behavior:
   Unclear. If this is another way to change datasource LOCALLY for the one 
chart, (1) the warning shouldn't be displayed and (2) the change should apply 
to the current chart. This change should not apply globally to all charts.
   
   
   
   #### How to reproduce the bug
   
   1. Go to Chart Explore
   2. Click on Edit Datasource
   3. On 1st tab (Source) change the name of table
   4. Save
   4. Nothing happens
   
   ### Environment
   
   - superset version: `master`
   
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version 
of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to