eschutho commented on a change in pull request #11289:
URL:
https://github.com/apache/incubator-superset/pull/11289#discussion_r508912842
##########
File path: superset-frontend/src/explore/components/controls/MetricsControl.jsx
##########
@@ -337,7 +337,11 @@ export default class MetricsControl extends
React.PureComponent {
<OnPasteSelect
isMulti={this.props.multi}
name={`select-${this.props.name}`}
- placeholder={t('choose a column or aggregate function')}
+ placeholder={
+ this.props.multi
+ ? t('choose one or more column or aggregate function')
Review comment:
I went back and forth on that too, and didn't even find anything
definitive in the grammar handbooks, but I agree that the plural sounds more
natural .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
