rusackas commented on a change in pull request #11289:
URL:
https://github.com/apache/incubator-superset/pull/11289#discussion_r508918268
##########
File path: superset-frontend/src/explore/components/controls/MetricsControl.jsx
##########
@@ -337,7 +337,11 @@ export default class MetricsControl extends
React.PureComponent {
<OnPasteSelect
isMulti={this.props.multi}
name={`select-${this.props.name}`}
- placeholder={t('choose a column or aggregate function')}
+ placeholder={
+ this.props.multi
+ ? t('choose one or more column or aggregate function')
Review comment:
It doesn't seem like there IS a definitive answer... the rules conflict!
The [Proximity
Rule](https://www.thoughtco.com/proximity-agreement-grammar-1691697) says you
should go with whichever is closer to the verb. In this case, that'd be
"choose", so you would go with "column or agregate function".
However, the [Notional
Agreement](https://www.merriam-webster.com/words-at-play/notional-agreement-subject-verb-principle-proximity)
seems to back us up here that these are cognitively a collection, so the
plural treatment makes more sense.
> "Don't take any notice of teachers and textbooks in such matters. Nor of
logic. It is good to say 'More than one passenger was hurt,' although more than
one equals at least two and therefore logically the verb ought to be plural
were not singular was!"
_–– CS Lewis_
+1 for team plural. And yes, I'm going back to what I _should_ be doing, now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
