junlincc edited a comment on pull request #11854: URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738138322
> Should X rows retrieved be showing proper value when we apply the search filter? i thought about that, let's keep showing the #row retrieved, because the search filter result is temporary for this PR, I will get some user feedback later, if change is needed, we can address later. > During my tests it stil crashes when I set big amount of data but as it was said - it is not introduced by this PR. i assigned this issue to another external team member, no need to worry > Unfortunately, the result is that a chart is visible under the Data button. @junlincc Do you think that's acceptable? this is not ideal of course, if it takes less than a day to fix, let's fix. if more, let's open a separate issue later. there are way too many small cosmetic issues in this product, if it's not a deal breaker, we can always address separately. @adam-stasiak @kgabryje ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
