mistercrunch commented on a change in pull request #11922:
URL:
https://github.com/apache/incubator-superset/pull/11922#discussion_r535848059
##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -76,6 +85,7 @@ class TabbedSqlEditors extends React.PureComponent {
queriesArray: [],
dataPreviewQueries: [],
hideLeftBar: false,
+ databaseIds: getDatabasesIds(),
Review comment:
Mmmh, we're already pulling the database list to populate the dropdown,
can we just use/share that? Wondering why it used to work and doesn't anymore
(?)
It seems to me like this belongs somewhere in redux land.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
