mistercrunch commented on a change in pull request #11922:
URL:
https://github.com/apache/incubator-superset/pull/11922#discussion_r536234459
##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -76,6 +85,7 @@ class TabbedSqlEditors extends React.PureComponent {
queriesArray: [],
dataPreviewQueries: [],
hideLeftBar: false,
+ databaseIds: getDatabasesIds(),
Review comment:
I'm ok with this as a quick fix to unblock if we revisit quickly. But I
don't think fetching in components is great, especially in constructors as it
will hold things up.
Pointing out two relevant redux actions that could be useful for the
following PR:
https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/SqlLab/actions/sqlLab.js#L436
https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/SqlLab/actions/sqlLab.js#L744
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
