hughhhh commented on a change in pull request #11922:
URL:
https://github.com/apache/incubator-superset/pull/11922#discussion_r536189285
##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -76,6 +85,7 @@ class TabbedSqlEditors extends React.PureComponent {
queriesArray: [],
dataPreviewQueries: [],
hideLeftBar: false,
+ databaseIds: getDatabasesIds(),
Review comment:
Currently the database selector is using `<SupersetAsyncSelect/>` which
doesn't allow the TabbedSqlEditors to have a reference for the databases
available. So i'm basically following the same pattern but in our component
`makeApi`.
This is blocking for this weeks release so I wanted to fix the issue, and
then I can look into moving this code into redux.
https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/components/DatabaseSelector.tsx#L222
##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -76,6 +85,7 @@ class TabbedSqlEditors extends React.PureComponent {
queriesArray: [],
dataPreviewQueries: [],
hideLeftBar: false,
+ databaseIds: getDatabasesIds(),
Review comment:
@mistercrunch
Currently the database selector is using `<SupersetAsyncSelect/>` which
doesn't allow the TabbedSqlEditors to have a reference for the databases
available. So i'm basically following the same pattern but in our component
`makeApi`.
This is blocking for this weeks release so I wanted to fix the issue, and
then I can look into moving this code into redux.
https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/components/DatabaseSelector.tsx#L222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
