ktmud commented on a change in pull request #11951:
URL:
https://github.com/apache/incubator-superset/pull/11951#discussion_r539091919
##########
File path: superset-frontend/src/dashboard/components/SaveModal.tsx
##########
@@ -137,17 +152,17 @@ class SaveModal extends React.PureComponent {
t('You must pick a name for the new dashboard'),
);
} else {
- this.onSave(data, dashboardId, saveType).then(resp => {
+ this.onSave(data, dashboardId, saveType).then((resp: any) => {
if (
saveType === SAVE_TYPE_NEWDASHBOARD &&
resp &&
resp.json &&
resp.json.id
) {
- window.location = `/superset/dashboard/${resp.json.id}/`;
+ window.location.href = `/superset/dashboard/${resp.json.id}/`;
Review comment:
Setting `location` is equivalent to setting `location.href`. Old
JavaScript programmers would know 😉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
