pkdotson commented on a change in pull request #12008:
URL:
https://github.com/apache/incubator-superset/pull/12008#discussion_r544587893
##########
File path:
superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -70,19 +73,23 @@ const Styles = styled.div`
svg.datasource-modal-trigger {
color: ${({ theme }) => theme.colors.primary.base};
- vertical-align: middle;
+ vertical-align: ${({ theme }) => theme.gridUnit + 2}px;
cursor: pointer;
}
-`;
-
-/**
- * <Col> used in column details.
- */
-const ColumnsCol = styled(Col)`
- overflow: auto; /* for very very long columns names */
- white-space: nowrap; /* make sure tooltip trigger is on the same line as the
metric */
- .and-more {
- padding-left: 38px;
+ .title-select {
+ width: ${({ theme }) => theme.gridUnit * 52}px;
+ display: inline-block;
+ background-color: #f0f0f0;
Review comment:
yep!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
