[GitHub] [incubator-superset] junlincc edited a comment on pull request #12008: feat(explore-datasource): add new datasource tab to explore view

[GitBox]

junlincc edited a comment on pull request #12008:
URL: 
https://github.com/apache/incubator-superset/pull/12008#issuecomment-747081801


   Before
   <img width="1781" alt="Screen Shot 2020-12-16 at 2 33 16 PM" 
src="https://user-images.githubusercontent.com/67837651/102414641-c01cc300-3fab-11eb-8a5d-250875175607.png";>
   
   Now
   <img width="1780" alt="Screen Shot 2020-12-16 at 2 45 16 PM" 
src="https://user-images.githubusercontent.com/67837651/102415612-56051d80-3fad-11eb-86f1-ba91fdf91f60.png";>
   
   > And finally, it looks like the table in your screenshot got cut off even 
though it hadn't reached the bottom of the screen. Is that something that was 
changed here, or did it always happen? Seems like it would be better to allow 
the chart to go full height if the space allows
   
   im not sure why the data section is not showing in @pkdotson's screen 
shot... 
   @etr2460 i can confirm that pivot table cutoff is a minor existing cosmetic 
issue, also happening in table viz. we can address it separately. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org