pkdotson commented on a change in pull request #12008:
URL:
https://github.com/apache/incubator-superset/pull/12008#discussion_r544589632
##########
File path: superset-frontend/src/explore/components/ControlPanelsContainer.jsx
##########
@@ -159,7 +159,11 @@ class ControlPanelsContainer extends React.Component {
// When the item is a React element
return controlItem;
}
- if (controlItem.name && controlItem.config) {
+ if (
+ controlItem.name &&
+ controlItem.config &&
+ controlItem.name !== 'datasource'
Review comment:
The datasource control needs to be passed in and filtered out of the
view because it is tied to the logic of fetching the chart data through form
data. If it's removed it breaks the chart.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
