villebro commented on pull request #12095: URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747603583
@kgabryje during testing I noticed some strange behavior, some of which was actually present from before, like inconsistent conversion of simple filters to sql filters and labels and how the `isValid()` function deals with missing values, causing false positives. I have a follow up PR that's mostly done which makes more sense to open after this is merged. So I suggest merging this when you feel this is ready and has had some more review and I'll follow up with a PR to fix some of those inconsistencies. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
